Skip to main content

To code review or not to code review?

There are many articles on the web about how to do good code reviews, with mostly all of them either discussing their merits or how to obtain maximum value from them.

In a new role I've recently helped introduce and roll out the agile process and to start with as part of each story we always added a task to "code review" all work. We made sure that differences from source control were used to make sure only the changes made were reviewed, made sure that everyone had chance to partake in reviews so it wasn't just one or two people providing all the feedback on the other team members work. It worked well, the reviews were productive and provided really good feedback for everyone.

But there was something about them that didn't feel right for the entire team, but it was the sprint planning process of tasking the stories that gave us the answer to what was bothering us. For every story we added the code review task to the END of the story, which of course by it's very nature was when all the development had been done! We analysed most of the feedback that came out of the review process and realised that, similar to the wedding singer, that information would have been useful to us "yesterday".

So as a little experiment we added a task right at the beginning of the story that involved at least 2 developers, sometimes a tester and for more complex stories, the entire team. Outside of the task planning session the developer(s) assigned the task spend 30-60 minutes detailing the approach they intend to take to solve the story - the other participants in the process get to question the approach and by the end of the discussion we've normally ironed out all the bumps. During these experimental stories we kept the code review task, but the initial discussion task along with taking a TDD approach coding against Gherkin provided by the test team we quickly identified that the code reviews had become redundant.

We've now taken the decision to remove the code review task completely and haven't noticed any decrease in code quality or maintainability. The number of issues reported in the produced code has stayed pretty constant, but we're no longer have to spend any time at the end of the story reworking any code as a result of review feedback!

Comments

Popular posts from this blog

Why do my Android Notification only appear in the status bar?

I'm definitely getting back into Android development, I'm remembering that feeling of 'Surely this should be easier than this!'. All I wanted to do was to schedule a local notification which behaved similar to a push notification pop-up. That is, as well as showing the small icon in the status bar I wanted it to pop up on screen to notify the end user. All seems fairly easily, I found this code for how to schedule a notification. That all worked perfectly, apart from the notification would only appear in the status bar. Searching around I found loads of different answers / solutions, mostly all saying the same thing:It only worked if you used 'NotificationCompat.Builder' in place of 'Notification.Builder', orYou had to set the priority to 'NotificationCompat.PRIORITY_HIGH'As usually happens, none of these solutions worked for me until I added in the missing piece of the jigsaw:- '.setDefaults(Notification.DEFAULT_ALL)'. For me this…

Do "Task Hours" add anything in Scrum (Agile)?

What do task hours add to the overall process in scrum?This was a question that has arisen from all team members in both instances that I've helped teams switch over to scrum. The benefits of artifacts like the comparative story point estimation, the 2 week sprints, stand-ups and the end of sprint demo have been self evident to the team, but as one I think every team member has expressed dismay when it comes to task planning and estimating each task in hours. Left unchecked there is a natural tendency for people to actually begin to dread the start of each sprint purely due to the task planning session.In my current role we've been lucky to investigate this further as a team.The team sat down to discuss the problems it was experiencing with estimating tasks in hours and the following common themes appeared:It is hard: Maybe it shouldn't be, but time estimation is hard! Story points are comparative and abstracted making them easier to determine, but time estimate is gen…

IPhone hangs when running from XCode

I've had this happen a couple of times now and the first time was a little worrying that I'd bricked my iPhone. Basically I was running an application on my phone via XCode and when rebuilding an updated version it failed with a "busy" error message. Stopping XCode and unconnecting my phone had no effect, the phone was stuck displaying the loading screen of the application and wouldn't respond to any key commands. To fix you have to hard reboot, holding the power and home button until the phone reboots - doesn't lose any of the data you have on your phone (a concern the first time I did it).