Skip to main content

Improving “Boiler Plate” Data-Reader Code – Part 5

In this post we will extend the query functionality to handle stored procedures with parameters. To do this we need to create a new query type interface with an example implementation:

public interface IDefineAStoredProcedureQuery : IQuery
{
string StoredProcName { get; }
IList<SqlParameter> Parameters { get; }
}
 
public class GetCustomersByFirstName : IDefineAStoredProcedureQuery
{
public GetCustomersByFirstName(string firstName)
{
this.Parameters = new List<SqlParameter> { new SqlParameter("FirstName", firstName) };
}
 
public string StoredProcName { get { return "GetCustomersByFirstName"; } }
 
public IList<SqlParameter> Parameters { get; private set; }
}

Now that we have the ability to create stored procedure queries we need something to handle them. To do this we need a concrete implementation of the interface "IHandleAQuery":

public class StoredProcedureQueryHandler : IHandleAQuery
{
public void Assign(SqlCommand command, IQuery query)
{
var castQuery = query as IDefineAStoredProcedureQuery;
command.CommandType = CommandType.StoredProcedure;
command.CommandText = castQuery.StoredProcName;
 
if (castQuery.Parameters != null)
{
command.Parameters.AddRange((SqlParameter[])castQuery.Parameters);
}
}
}

Finally we update our factory to handle the new query interface and return the correct handler:

public static class QueryHandlerFactory
{
public static IHandleAQuery Create(IQuery query)
{
if (query is IDefineCommmandTextQuery)
{
return new HandleCommandTextQuery();
}
 
if (query is IDefineAStoredProcedureQuery)
{
return new StoredProcedureQueryHandler();
}
 
var ex = new NotSupportedException();
ex.Data.Add("IQuery Type", query.GetType());
throw ex;
}
}

This can now be called using the following code; which should highlight the power of this repository pattern. Whilst we have implemented quite a lot of code behind the scenes the only change the consumer sees is what type of query object they are passing in.

var customers = new SqlRepository(connectionString).Get(
new GetCustomersByFirstName("Paul"),
new CustomerDRConvertorPart2()).ToList();

Comments

Popular posts from this blog

Mocking HttpCookieCollection in HttpRequestBase

When unit testing ASP.NET MVC2 projects the issue of injecting HttpContext is quickly encountered.  There seem to be many different ways / recommendations for mocking HttpContextBase to improve the testability of controllers and their actions.  My investigations into that will probably be a separate blog post in the near future but for now I want to cover something that had me stuck for longer than it probably should have.  That is how to mock non abstract/interfaced classes within HttpRequestBase and HttpResponseBase – namely the HttpCookieCollection class.   The code sample below illustrates how it can be used within a mocked instance of HttpRequestBase.  Cookies can be added / modified within the unit test code prior to being passed into the code being tested.   After it’s been called, using a combination of MOQ’s Verify and NUnit’s Assert it is possible to check how many times the collection is accessed (but you have to include the set up calls) and that the relevant cookies have …

Injecting HttpContextBase into an MVC Controller

It is a shame that when the ASP.NET MVC framework was released they did not think to build IoC support into the infrastructure. All the major components of the MVC engine appear to magically inherit instances of HttpContext and it’s related objects – which can cause no end of problems if you are trying to utilise Unit Testing and IoC. Reading around various articles on the subject just to get around this one problem requires the implementation of several different concepts and you are still left with a work around. The code below, along with the other links referenced in this article is my stab at resolving the issue. There’s probably nothing new here, but it does attempt to relate all the information needed to do this for Castle Windsor. The overview is that all controllers will need to inherit from a base controller, which takes an instance of HttpContext into it’s constructor. It then overrides the property HttpContext in the main controller class, supplying it’s own version…

Problem installing AWS CLI

It never feels like a good start when you're trying to start out with something and the install fails with an obscure error! I was just trying to install the Amazon CLI following the instructions at https://aws.amazon.com/cli/ and ran into the following error when running 'pip install awscli': Collecting awscli Could not find a version that satisfies the requirement awscli (from versions: ) No matching distribution found for awscli I appeared to have a correct version of Python installed (v2.7) and checking "PIP -v" indicated that 9.0.1 was installed. That all seemed to tick the required boxes but digging around a little more I did see that some people had had issues with various versions of PIP so I found / ran the following to upgrade to the latest vesion: curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py python get-pip.py This installed v9.0.3 of PIP which burst into life when I re-ran 'pip install awscli' and everything seems to be ok. Like…